Potter began his career at Celtic, but failed to make a senior appearance for them. Potter was highly rated at Celtic Park and captained the reserve side, most notably on 16 February 1999, when Mark Viduka made his first appearance in a Celtic shirt in a 4–2 victory against Motherwell. Potter travelled to Portugal with the first team squad and was an unused substitute in Wim Jansen's final game in charge against Sporting Lisbon, but a change in management from Jansen to Josef Venglos signalled the end of Potter's career at the club. After leaving Celtic, Potter joined hometown team Dunfermline Athletic and spent three years at East End Park. In 2002, he joined Clyde. He made his debut on the same day he joined Clyde, in an evening fixture against Partick Thistle. At the beginning of the 2004–05 season, Potter was appointed captain of Clyde, and started every single game for the Bully Wee that season. He joined St Mirren in July 2005 and won promotion to the Scottish Premier League in his first season. At the beginning of the 2008–09 campaign, Saint's manager Gus MacPherson named Potter as captain, a position he held for three seasons. However, towards the end of the 2010–11 season, Potter - along with 9 other players at St Mirren - was told that his contract would not be renewed and he would be allowed to leave the club on a free transfer. After seeing out his contract at St Mirren, Potter joined his former St Mirren teammate Paul Gallacher at Dunfermline Athletic, beginning his second spell at the club. He became U20s player/coach assisted by Craig Dargo in 2012.
Coaching career
Potter took control of the Dunfermline Athletic first team in December 2014, after Jim Jefferies left the club. It was announced at the end of the season that, after failing to secure promotion or a play off position, Potter would step down as manager and return to his position as head coach. Although having not played since May 2014, Potter was registered as a player for the Pars during the 2015–16 season, and was an unused substitute in a number of first-team matches. Potter continued as under 20s manager for Dunfermline into the 2016–17 season, and played for the side in a one-all draw against Inverness under 20s in April 2017. Potter was also linked with becoming assistant manager of St Mirren in October 2016, after former teammate Jack Ross was appointed manager of the Paisley club. Potter did eventually team up with Ross in June 2018, joining Sunderland as first team coach. He then moved to Hibernian in November 2019, as assistant to Ross.
