She was commanded for her entire career by Lieutenant-Commander Malcolm David Wanklyn, and became the most successful British submarine of the Second World War. After a working up period, she left for Malta on 10 December 1940 and was attached to the 10th Submarine Flotilla based there. She completed 24 patrols, sinking 93,031 tons of enemy shipping including the Libeccio after the Battle of the Duisburg Convoy, two submarines, three troopships, six cargo ships, an auxiliary ship, and an auxiliary minesweeper. Wanklyn was awarded the Victoria Cross for a patrol in her in 1941, which included an attack on a particularly well-defended convoy on 24 May 1941 in which Upholder sank the Italian troop ship. On 28 July 1941 she damaged the Italian cruiser Giuseppe Garibaldi. On 18 September 1941 she sank two troopships within hours of each other: the sister ships and . Upholder also damaged the German freighter Duisburg, the French tanker Capitaine Damiani, the Italian freighters Dandolo and Sirio and destroyed the wreck of the German freighter Arta already grounded after the battle of Tarigo convoy.
Sinking
Upholder was lost with all hands on her 25th patrol, which was to have been her last before she returned to England. She left for patrol on 6 April 1942 and became overdue on 14 April. On 12 April she was ordered, with and to form a patrol line to intercept a convoy, but it is not known whether she received the signal.
Theories about her loss
The most likely explanation for her loss is that after being spotted by a reconnaissance seaplane, she fell victim to depth charges dropped by the Italian Orsa-class torpedo boat northeast of Tripoli on 14 April 1942 in the position, although no debris was seen on the surface. The attack was 100 miles northeast from Wanklyn's patrol area and he may have changed position to find more targets. It is also possible that the submarine was sunk by a mine on 11 April 1942 near Tripoli, when a submarine was reported close to a minefield. A third and less likely theory came from an alleged air and surface attack on a submarine contact by German aircraft and the escort of a convoy on 14 April off Misrata, but no official Axis record of this action was found after the end of World War II. A more recent research carried out by Italian naval specialist Francesco Mattesini points to a German aerial patrol supporting the same convoy, comprising two Dornier Do 17 and two Messerschmitt Bf 110 aircraft, that attacked an underwater contact with bombs two hours before the Pegaso incident. The author also asserts that the seaplane crew was unsure if the target they pinpointed to Pegaso was a submarine or a school of dolphins. Mattesini admits the possibility that Pegaso could have finished off the submarine previously damaged by the German aircraft.
Tribute
When, on 22 August 1942, the Admiralty announced her loss, the communiqué carried with it an unusual tribute to Wanklyn and his men: "It is seldom proper for Their Lordships to draw distinction between different services rendered in the course of naval duty, but they take this opportunity of singling out those of HMS Upholder, under the command of Lt.Cdr. David Wanklyn, for special mention. She was long employed against enemy communications in the Central Mediterranean, and she became noted for the uniformly high quality of her services in that arduous and dangerous duty. Such was the standard of skill and daring set by Lt.Cdr. Wanklyn and the officers and men under him that they and their ship became an inspiration not only to their own flotilla, but to the Fleet of which it was a part and to Malta, where for so long HMS Upholder was based. The ship and her company are gone, but the example and inspiration remain." In all, Upholder was credited with having sunk 97,000 tons of enemy shipping, in addition to three U-boats and one destroyer. Quoted by Admiral of the Fleet, The Lord Fieldhouse GCB, GBE probably during the Falklands War: "I can do no better than repeat the unique message following the sinking of HMS Upholder on April 14th 1942 : 'The ship and her company are gone but the example and inspiration remain'"