Smith attended Abronhill High School in Cumbernauld and joined the Hearts youth setup aged 10. A member of Hearts under 19 team Smith made his first team debut as a substitute against Dundee United on 15 May 2011. His performance for the under 19 squad in the early part of the 2011–12 season earned him a new three-year contract extending his stay with the club until 2014. With Hearts in financial difficulty and wanting to bring through members of their under-19 squad into the first team, Smith was sent on loan to Raith Rovers to gain first team experience. The 2013–14 season would be darkest time for Smith, as Hearts entered administration and were deducted 15 points ahead of the new season. On 2 January 2014, Smith scored his only goal for Hearts, in a 2–1 loss against Hibernian. During a semi-final match against Inverness CT, Smith fractured his knee in the first half and have to be substituted. After a scan, it announced that Smith would be out for six weeks. Smith would make his return, in a 2–1 loss against Dundee United on 21 March 2014. However, Smith was unable to help the club survive relegation. At the end of the season, Smith signed a contract extension with the club, keeping until 2015. During his final month at Hearts, Smith lost his first team opportunities following new arrivals and was told he could leave Hearts.
Raith Rovers
On 21 November 2011, Smith joined Scottish First Division side Raith Rovers on a month's loan deal. Making his debut on 26 November 2011 scoring their second goal in a 3–2 win against Hamilton. After six appearances on 4 January 2012, his loan was extended for another month. He returned to Hearts on 30 January 2012. On 31 August 2012, he returned to the club on loan.
Falkirk
On 1 September 2014, Smith moved to Falkirk, signing a two-year contract. He made his debut on 13 September 2014, as Falkirk drew 1–1 with Queen of the South. Smith then scored his first goal and provided two assists, in a 6–0 win over Cowdenbeath on 25 October 2014.
Dumbarton
After leaving Falkirk, Smith signed for Scottish Championship rivals Dumbarton in June 2016. He scored his first goal for the club in a 3–3 draw with Peterhead in July 2016.. After being an ever present for the club, playing in all 43 games of the season, Smith agreed to a new 1 year deal in May 2017 Smith was released by the club in May 2018.
Stranraer
Smith signed for Stranraer on 22 May 2018. David then signed for Grangemouth-based Syngenta Juniors on 29 May 2020. He’s currently being sponsor by Syngenta Juveniles Cerebral Palsy FC.
